Skip to content

ignore bid from excited builders - #11239

Merged
mehdi-aouadi merged 10 commits into
Consensys-Incorporated:masterfrom
mehdi-aouadi:11220-reject-exited-builders-bids
Sep 14, 2026
Merged

mehdi-aouadi merged 10 commits into
Consensys-Incorporated:masterfrom
mehdi-aouadi:11220-reject-exited-builders-bids

Conversation

@mehdi-aouadi

@mehdi-aouadi mehdi-aouadi commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

PR Description

Ignore bids from excited builders

Fixed Issue(s)

fixes #11220

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Medium Risk
Changes EPBS execution payload bid gossip validation on the Gloas path; incorrect exit matching could wrongly ignore or accept bids, but scope is limited to one new rule with deferral behavior.

Overview
Adds a Gloas gossip validation rule on execution payload bids so a builder cannot keep bidding when the parent execution payload may exit them.

When a bid’s parent_block_hash matches the head’s latest execution payload hash, the validator loads that parent envelope (when envelopes apply at the parent slot) and IGNOREs the bid if its builder_exits include a request whose pubkey and source address both match the bidding builder. If the parent envelope is not imported yet, the bid is saved for future processing instead; the check is skipped when the parent predates envelope availability or when the bid does not extend the latest payload.

Tests cover matching exits, partial field matches, non-latest parents, deferred validation, and pre-Gloas parents.

Reviewed by Cursor Bugbot for commit 28cbf2c. Bugbot is set up for automated code reviews on this repo. Configure here.

zilm13
zilm13 previously approved these changes Sep 4, 2026

@zilm13 zilm13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi self-assigned this Sep 7, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 568357a. Configure here.

@mehdi-aouadi
mehdi-aouadi requested a review from zilm13 September 9, 2026 16:53

@zilm13 zilm13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi
mehdi-aouadi enabled auto-merge (squash) September 11, 2026 07:51
@mehdi-aouadi
mehdi-aouadi merged commit 05a0dee into Consensys-Incorporated:master Sep 14, 2026
93 checks passed
@mehdi-aouadi
mehdi-aouadi deleted the 11220-reject-exited-builders-bids branch September 14, 2026 08:23
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject bids from builders exited by the parent's payload

2 participants